Conversation
Contributor
Author
|
I'm running into a newfound problem with this module. When I run: I receive: I've done the typical trouble shooting (confirmed I'm in the correct conda environment, have the appropriate git branch activated, checked the import statements and function to make sure it's in line with other modules, and, of course, shut it down and started it up again) so I'm not sure why I'm getting this issue. @weiji14 @seisman any ideas? |
weiji14
reviewed
May 18, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
May 19, 2021
maxrjones
reviewed
May 23, 2021
31 tasks
Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
maxrjones
approved these changes
May 24, 2021
Member
|
@willschlitzer Feel free to merge this PR after all tests pass. |
seisman
reviewed
May 24, 2021
weiji14
requested changes
May 24, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
May 26, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Just some final suggestions. Feel free to merge after the tests pass.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Add grdlandmask.py and test_grdlandmask.py Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com> Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wraps the
grdlandmaskmodule.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version