Closed
Conversation
Contributor
Author
|
I wasn't sure about the etiquette/procedures for taking on another author's pull request (in this case #636), so I opened this PR to wrap |
Member
|
@willschlitzer, I would suggest continuing work on that #636 PR instead of starting a new one here. People (especially newcomers) put a lot of work into making a Pull Request and it is best to give them credit for their original work. There could also be reviews in the orginal PR that we want to keep (though not much in this case). As a maintainer, you should be able to commit directly to that branch, and I would start with a branch update from master (though maybe ping the original author first to check). C.f. #525 where I continued work on someone's old PR after asking for permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wraps the gmt module
xyz2grd.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version