Conversation
weiji14
left a comment
There was a problem hiding this comment.
Thanks @willschlitzer! Just a few suggestions regarding the use of common aliases.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Looks good to me. But please hold off on merging until we decide on whether we want a PyGMT v0.4.1 release, or go straight to v0.5.0 as discussed in #1356 (comment)
weiji14
left a comment
There was a problem hiding this comment.
Thanks for your patience @willschlitzer, now that the v0.4.1 tag is behind, we can finally finish this PR (and all the other ones you have lined up). Could you please resolve the conflict on decorators.py and fix one tiny issue I suggested below?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
|
@weiji14 I made the changes you suggested |
michaelgrund
left a comment
There was a problem hiding this comment.
Fine to merge after the suggestions by @seisman are implemented!
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
pygmt/src/grdsample.py
Outdated
| @use_alias( | ||
| G="outgrid", | ||
| J="projection", | ||
| I="increment", |
There was a problem hiding this comment.
It seems other modules (e.g., grdfilter) use the alias spacing rather than increment. We should keep the alias consistent, no?
*Wrap GMT module grdsample *Add tests for grdsample Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull requests wraps the GMT module
grdsample.Fixes #1422
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version