Conversation
seisman
reviewed
Dec 30, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Dec 30, 2021
seisman
added
the
final review call
michaelgrund
approved these changes
Dec 30, 2021
weiji14
reviewed
Dec 30, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
reviewed
Jan 1, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
reviewed
Jan 2, 2022
examples/get-started/first_figure.py
Outdated
| # The ``frame`` parameter is used to add a frame to the figure. For now, it | ||
| # will be set to ``True`` to use default settings, but later tutorials will | ||
| # show how ``frame`` can be used to customize the axes, gridlines, and titles. | ||
| # will be set to ``"a"`` to **a**nnotate the axes automatically. |
Member
There was a problem hiding this comment.
Oops, forgot that this is RST and not markdown. How do you set bold text again?
seisman
reviewed
Jan 3, 2022
Contributor
Author
|
@GenericMappingTools/pygmt-admin Can I get someone to merge this? Thanks! |
willschlitzer
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally intended to add a second page to the tutorial that covered adding a title, but changed my mind and think the title section would be more appropriate in first_figure.py rather than adding a separate page, which this PR does.
Additionally, to reduce confusion over switching between
frame=Trueand frame=["a", "+tMaine"], this changes the frame example to useframe="a".Addresses #770
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version