Conversation
stickler-ci
reviewed
Jun 1, 2018
| # ... mode = lib.get_constant('GMT_MODULE_CMD') | ||
| # ... with lib.log_to_file() as logfile: | ||
| # ... call_module = lib.get_libgmt_func('GMT_Call_Module') | ||
| # ... status = call_module(lib.current_session, 'info'.encode(), |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
There seems to be a segfault problem (#164) that doesn't happen on Linux. I'm re-enabling the Mac build to check if it happens on Travis as well.
stickler-ci
reviewed
Jun 14, 2018
gmt/tests/test_clib.py
Outdated
| def test_set_log_file(): | ||
| "log_to_file should not crash even if not given anything" | ||
| with LibGMT() as lib: | ||
| with lib.log_to_file() as log: |
There was a problem hiding this comment.
F841 local variable 'log' is assigned to but never used
Member
Author
|
Figured out the problem and fixed it in #188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a segfault problem (#164) that doesn't happen on
Linux. I'm re-enabling the Mac build to check if it happens on Travis as
well.