Figure.text: Support passing in a list of angle/font/justify values#2720
Merged
Figure.text: Support passing in a list of angle/font/justify values#2720
Conversation
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit c39f196 |
seisman
commented
Oct 7, 2023
Comment on lines
-42
to
-44
| angle="sequence_comma", | ||
| font="sequence_comma", | ||
| justify="sequence_comma", |
Member
Author
There was a problem hiding this comment.
These lines were initially added in #321, but they should NOT be like this.
seisman
commented
Oct 7, 2023
michaelgrund
approved these changes
Oct 16, 2023
Member
|
This is a nice improvement of the |
Member
Author
|
Yes, please do it if you're interested. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of proposed changes
Address an old feature request #483.
Example:
Preview:

Note: Need to fix the bug in #2719 first.Closes #483.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version