Figure.legend: Refactor to simplify the logic of checking legend specification#3437
Merged
Figure.legend: Refactor to simplify the logic of checking legend specification#3437
Conversation
seisman
commented
Sep 11, 2024
| kwargs["F"] = box | ||
|
|
||
| kind = data_kind(spec) | ||
| if kind not in {"vectors", "file"}: # kind="vectors" means spec is None |
Member
Author
There was a problem hiding this comment.
This line can also be written as:
if spec is not None or kind != "file"
It's written in the current way so that this line can be extended to check "stringio" kind with minor changes (xref: #3326).
It's not straightforward to see why kind="vectors" means spec is None. That's also why I want to refactor the data_kind function in #3351.
775eaad to
ff90b2e
Compare
michaelgrund
approved these changes
Sep 12, 2024
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR contains a subset of changes in PR #3326. I open this PR so that PR #3326 can be smaller and easier for review.
This PR refactors the following codes:
to
The pros are: