GMTDataArrayAccessor: Simplify the codes for the grid registration and gtype during initialization#3483
Merged
GMTDataArrayAccessor: Simplify the codes for the grid registration and gtype during initialization#3483
Conversation
seisman
added
maintenance
…d gtype during initilization
seisman
force-pushed
the
refactor/accessor
branch
from
3eb1b30 to
0ef8b0c
Compare
seisman
added
final review call
Member
Author
|
Will merge in 24 hours. |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
weiji14
approved these changes
Oct 7, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Instead of using the complicated
if-elseandtry-exceptstatements, this PR refactors the codes by initializing grid registration and gtype to the default values first and then see if we can determine their values usinggrdinfo.The original codes were added in #500 and #2009.