clib: Switch the order of if-conditions to improve the Session.call_module performance#3502
Merged
clib: Switch the order of if-conditions to improve the Session.call_module performance#3502
Conversation
…odule performance
seisman
added
maintenance
michaelgrund
approved these changes
Oct 10, 2024
michaelgrund
added
final review call
weiji14
approved these changes
Oct 10, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
removed
final review call
seisman
added a commit
that referenced
this pull request
Oct 16, 2024
…odule performance (#3502) Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In the old version, we first check if
argsis a string, if not then check if it's a list. The codes are like:Since in most cases,
argsis a list, it's better to check against list first, then string. In this way, the first if-condition is True, so it's slightly faster, although the performance improvement can be negligible.