Skip to content

Add a test to make sure shift_origin does not crash#580

Merged
seisman merged 2 commits intomasterfrom
test-shift_origin
Sep 4, 2020
Merged

Add a test to make sure shift_origin does not crash#580
seisman merged 2 commits intomasterfrom
test-shift_origin

Conversation

@seisman
Copy link
Member

@seisman seisman commented Sep 4, 2020

Description of proposed changes

Call shift_origin() before setting -J and -R. It crashes for GMT<=6.1.0,
but works after GMT>=6.1.1.

Closes #514.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@vercel vercel bot temporarily deployed to Preview September 4, 2020 03:36 Inactive
@seisman seisman added the maintenance Boring but important stuff for the core devs label Sep 4, 2020
@seisman seisman added this to the 0.2.x milestone Sep 4, 2020
@seisman seisman requested a review from weiji14 September 4, 2020 03:37
@seisman seisman merged commit 08aa36f into master Sep 4, 2020
@seisman seisman deleted the test-shift_origin branch September 4, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure.shift_origin() does not work

2 participants