Conversation
| Force output grid to be gridline (g) or pixel (p) node registered. | ||
| Default is gridline (g).""", | ||
| "t": """\ | ||
| transparency : float |
There was a problem hiding this comment.
transparency can also be an array for a few modules, e.g., plot, plot3d and text, so that symbols and texts can have varying transparency. It needs more work and should be addressed in separated PRs.
I will open a feature request after merging this PR.
There was a problem hiding this comment.
Ok, but could you add at least one unit test for transparency on a module that won't have array-like transparency inputs (e.g. image)?
There was a problem hiding this comment.
It means adding another baseline image to the repository. 😄
There was a problem hiding this comment.
Maybe just a gallery example then, if not too much work 😶 I suppose we could come up with a smart check_figures_equal test but happy to leave that to the next PR.
There was a problem hiding this comment.
There is an upcoming example in #607, but I'm not sure if the example does too many things (symbols, transparency and legends.).
There was a problem hiding this comment.
Ah right, missed the transparency part on that example. I don't think we can have too many examples, if anything we have too little right now (a lot of catching up to do with matplotlib at https://matplotlib.org/gallery/index.html)!
weiji14
left a comment
There was a problem hiding this comment.
Cool, I haven't actually used transparency before, but looks fine. An example would be nice 😉
| Force output grid to be gridline (g) or pixel (p) node registered. | ||
| Default is gridline (g).""", | ||
| "t": """\ | ||
| transparency : float |
There was a problem hiding this comment.
Ok, but could you add at least one unit test for transparency on a module that won't have array-like transparency inputs (e.g. image)?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
Add
transparency(alias of -t option) to all plotting modules.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.