Conversation
weiji14
left a comment
There was a problem hiding this comment.
Looks good! In terms of issues #364 and #638, do we want to:
- have this PR close them automatically (and have users install the GMT dev version using
conda install -c conda-forge/label/dev gmtsince conda-forge/gmt-feedstock#108 is merged). - wait until GMT 6.2.0 is released then manually close those two issues?
Also, what do you think about making a PyGMT v0.2.1 release soon-ish? There's a lot of good new documentation!
Both are OK for me. I think closing them now makes us easy to track high-priority issues.
Yes, that's why I want to push the merging of PRs like #480 and #482. |
|
BTW, I'm not sure if #638 is fixed by the upstream GMT updates. We need feedbacks from the user. |
Let's just close #364 for now (but keep it pinned), and leave #638 open for a bit longer
Cool, I've got a lot on my plate but will try and get on top of those. |
Description of proposed changes
The xarray shading issue in #364 was fixed by upstream GMT in GenericMappingTools/gmt#4328.
This PR updates the pytest xfail condition, so that the xarray shading test is expected to xfail only for GMT<=6.1.1.
Closes #364.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.