Conversation
weiji14
approved these changes
Nov 16, 2020
Member
weiji14
left a comment
There was a problem hiding this comment.
This PR tries to migrate the
coverageconfigurations from.coveragerctopyproject.toml. We may migrate more configurations (e.g.,black,pytest,setuptools-scm) in separate PRs.
Fully support this step-by-step move of all the configurations to pyproject.toml. Have a look too at https://python-poetry.org/ when you have time!
Member
Author
Read a little bit about poetry, but it seems poetry still doesn't officially support dynamic versioning from setuptools_scm. See python-poetry/poetry#140, python-poetry/poetry#693, https://github.com/mtkennerly/poetry-dynamic-versioning. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The project is using many different tools (e.g., black, coverage) and each tool may have many configurations, saved in different configurations files (e.g.,
.coveragerc,setup.cfg). PEP 518 introduced a standard configuration filepyproject.tomlwhere tools can put their configurations.This PR tries to migrate the
coverageconfigurations from.coveragerctopyproject.toml. We may migrate more configurations (e.g.,black,pytest,setuptools-scm) in separate PRs.Coverage configurations: https://coverage.readthedocs.io/en/latest/config.html
References:
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.