Let Figure.text() support record-by-record transparency#716
Merged
Conversation
dfcd84e to
088fe53
Compare
Member
Author
|
/format |
weiji14
reviewed
Dec 6, 2020
weiji14
reviewed
Dec 7, 2020
Member
weiji14
left a comment
There was a problem hiding this comment.
Style checks are failing, and we really need to refactor this text function (along with #483).
pygmt/base_plotting.py:1377:4: R0914: Too many local variables (16/15) (too-many-locals)
pygmt/base_plotting.py:1377:4: R0912: Too many branches (13/12) (too-many-branches)
Member
Author
Yes, let's leave it to future PRs. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR implements the record-by-record transparency feature for
Figure.text()function.Example:
Output:
Fixes #615.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically