Merged
Conversation
seisman
reviewed
Feb 4, 2021
2 tasks
seisman
reviewed
Feb 4, 2021
seisman
reviewed
Feb 4, 2021
seisman
reviewed
Feb 4, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
reviewed
Feb 5, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Fingers crossed that we can finalize this before the PyGMT meeting!
seisman
reviewed
Feb 5, 2021
Member
|
The PR looks good to me after addressing the above minor comments. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
approved these changes
Feb 5, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Phew, thanks for your patience @willschlitzer. Feel free to merge once the tests pass! 🚀
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
*Wrap inset function to use a context manager *Create src/inset.py and import inset function into base_plotting.py Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As discussed in #663, this is wrapping the GMT function
inset. After some back and forth (and an attempt at Option 2), this PR goes with Option 1 to use a context manager andwithstatement to callinset.Fixes #663
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically