[Build] Fix tools test on wheel#17
Merged
hughperkins merged 5 commits intomainfrom Jun 9, 2025
Merged
Conversation
Comment on lines
+8
to
+13
| # I don't want to make python/tools a module, and I don't want to move this tool | ||
| # into `taichi` namespace, so that leaves temporarily importing it somehow | ||
| tools_path = Path(__file__).parent.parent.parent / "python" / "tools" / "markdown_link_check.py" | ||
| spec = importlib.util.spec_from_file_location("markdown_link_check", tools_path) | ||
| markdown_link_check = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(markdown_link_check) |
There was a problem hiding this comment.
Isn't there any way we can solve this declaratively in pyproject.toml?
Collaborator
Author
There was a problem hiding this comment.
Well, yes, by putting this into taichi namespace, but this is strictly for use in CI, not part of Taichi product, so I'm not very keen on doing that. I suppose we could make a new namespace, like taichi-ci perhaps 🤔 Thoughts?
Collaborator
Author
There was a problem hiding this comment.
(I'm not incredibly keen on adding a new taichi-ci namespace to be honest. we could also have taichi.ci I suppose 🤔 )
Collaborator
Author
There was a problem hiding this comment.
(unless you're aware of some way of handling this in pyproject.toml , that does not involve either adding this to taichi namespace or similar?)
duburcqa
approved these changes
Jun 9, 2025
Contributor
duburcqa
left a comment
duburcqa
left a comment
There was a problem hiding this comment.
This is ugly but this part of the code is not critical so it is fine for me.
CharlesMasson
approved these changes
Jun 9, 2025
Collaborator
Author
|
Thanks! |
hughperkins
added a commit
that referenced
this pull request
Apr 26, 2026
Convert ScalarField.to_torch / to_numpy to thin calls into _interop.get_zerocopy_torch / get_zerocopy_numpy, mirroring the Ndarray migration in the previous commit. - Adds Field._invalidate_zerocopy_cache method (used by all subclasses) so the impl.reset() cache_holders loop has a single contract to call. - Adds ScalarField._zerocopy_cache as a cached_property; constructed once per instance instead of re-checking can_zerocopy on every call (closes review #17). - Registers ScalarField in pyquadrants.cache_holders on first cache access (closes review #18). - to_torch(copy=True) now zerocopies and clones rather than skipping zerocopy entirely (closes review #15, #16, #21); to_torch on Metal does both syncs (closes review #1, #22, #23). - to_numpy(copy=False) goes through numpy.from_dlpack directly, no torch round-trip and no torch import required (closes review #6). Default to_numpy semantic (copy=None) remains "independent copy" for lifetime safety; zero-copy is opt-in via copy=False.
hughperkins
added a commit
that referenced
this pull request
Apr 26, 2026
Convert MatrixField.to_torch / to_numpy to thin calls into _interop.get_zerocopy_torch / get_zerocopy_numpy. Adds a single _matrix_view_shape() helper that returns (expected_shape, as_vector); both to_torch and to_numpy now go through it instead of duplicating the n / m / keep_dims branching (closes review #13, #14). Same wins as the ScalarField migration: - _zerocopy_cache as cached_property (closes review #17) - automatic registration with pyquadrants.cache_holders (closes #18) - copy=True now zerocopies + clones (closes #15, #16, #21) - to_numpy(copy=False) goes through numpy.from_dlpack directly, no torch round-trip (closes #6) - Apple Metal double-sync via the centralised helpers (closes #1, #22, #23) The redundant reshape after zerocopy stays (DLPack returns the field's flat n-d shape; numpy/torch users expect the matrix dims appended) but it's now in one place per method instead of two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Fix tools test on wheel
copilot:summary
Walkthrough
copilot:walkthrough