Skip to content

[Build] Add mac build for Mac OS 14 and 15#5

Merged
hughperkins merged 29 commits intomainfrom
hp/mac-14-15
Jun 18, 2025
Merged

[Build] Add mac build for Mac OS 14 and 15#5
hughperkins merged 29 commits intomainfrom
hp/mac-14-15

Conversation

@hughperkins
Copy link
Copy Markdown
Collaborator

Issue: #

Brief Summary

Add mac build for Mac OS 14 and 15

Note that this will fail without a ton of additional changes.

  • open question whether we want to merge this in (with it failing), and then merge in additional things, bit by bit, until the mac build passes?
  • or create one 'big bang' pr
  • I feel that the first approach will be much easier, and cleaner?

copilot:summary

Walkthrough

copilot:walkthrough

@hughperkins
Copy link
Copy Markdown
Collaborator Author

Let's wait till linux runner is merged in before continuing with this one. Since we need some of the changes from linux runner. I'll set this to 'draft' for now.

@hughperkins hughperkins marked this pull request as draft June 3, 2025 02:18
Comment thread .github/workflows/mac_ondemand.yml Outdated
Comment thread .github/workflows/mac_ondemand.yml Outdated
@hughperkins hughperkins marked this pull request as ready for review June 4, 2025 20:31
@hughperkins hughperkins marked this pull request as draft June 4, 2025 20:31
@hughperkins hughperkins marked this pull request as ready for review June 4, 2025 22:26
@hughperkins
Copy link
Copy Markdown
Collaborator Author

Note: @duburcqa see discussion here, https://genesis-ai-company.slack.com/archives/C08UKDR6KGR/p1749076147261559 Your thoughts?

@hughperkins
Copy link
Copy Markdown
Collaborator Author

This might build now 🤔

@hughperkins
Copy link
Copy Markdown
Collaborator Author

Interesting: these are genuine failures:

FAILED tests/python/test_matrix.py::test_cross_scope_matrix_atomic_ops[arch=arm64-0]
FAILED tests/python/test_matrix.py::test_cross_scope_matrix_atomic_ops[arch=metal-1]
= 2 failed, 3414 passed, 317 skipped, 996 warnings, 6 rerun in 646.21s (0:10:46) =

@hughperkins
Copy link
Copy Markdown
Collaborator Author

Hi @duburcqa I've added skipif to one of the tests, for Mac.

@duburcqa duburcqa self-requested a review June 18, 2025 07:29


@test_utils.test(debug=True)
@pytest.mark.skipif(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is concerning but OK. Better be in a clean state and repair stuffs after.

Comment thread tests/python/test_matrix.py Outdated
@hughperkins hughperkins enabled auto-merge (squash) June 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants