Skip to content

fix: demote MSB3277 and add binding redirects #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcraciunas merged 3 commits into from
May 18, 2026
+25 −11
Merged

fix: demote MSB3277 and add binding redirects #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0512bd1
fix: silence MSB3277 noise and add binding redirects on .NET Framework
alafleur-genetec May 15, 2026
16c04e2
fix: address Copilot review on Directory.Build.props (#182)
alafleur-genetec May 15, 2026
6e56235
fix: update sln Solution Items to use Directory.Build casing
alafleur-genetec May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Samples/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<Project>
<PropertyGroup>
Comment thread
alafleur-genetec marked this conversation as resolved.
<!-- Demote MSB3277 from warning to message across all target frameworks. The version drift
Comment thread
alafleur-genetec marked this conversation as resolved.
between the SDK assemblies and their transitive dependencies (System.DirectoryServices.Protocols,
System.ServiceModel.*, Microsoft.Identity.*, etc.) is expected. On .NET Framework, runtime
resolution is handled by the binding redirects below. On .NET 8, the load context resolves
to the higher version automatically. -->
<MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);MSB3277</MSBuildWarningsAsMessages>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net481'">
<DefineConstants>$(DefineConstants);NETFRAMEWORK</DefineConstants>
<!-- Auto-generate binding redirects so .NET Framework executables resolve assembly version
drift between the SDK assemblies and their transitive dependencies. Class libraries
(Plugin / Workspace SDK samples) are loaded by host processes whose own .config governs
resolution, so this property is intentionally not extended to Library outputs. -->
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0-windows'">
<DefineConstants>$(DefineConstants);NET8_0</DefineConstants>
</PropertyGroup>
</Project>
0 Samples/Directory.build.targets → Samples/Directory.Build.targets
View file
Open in desktop
File renamed without changes.
9 changes: 0 additions & 9 deletions Samples/Directory.build.props
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions Samples/Genetec.Dap.CodeSamples.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{6D4CFB78-1DDF-442B-BB0F-6B119C559603}"
ProjectSection(SolutionItems) = preProject
.editorconfig = .editorconfig
Directory.build.props = Directory.build.props
Directory.build.targets = Directory.build.targets
Directory.Build.props = Directory.Build.props
Directory.Build.targets = Directory.Build.targets
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Media SDK", "Media SDK", "{949B9098-D0C6-4E6C-BAB4-7253789645C1}"
Expand Down