docs: fix build-from-source instructions and add Claude CLI version note#110
docs: fix build-from-source instructions and add Claude CLI version note#110Kevinsillo wants to merge 1 commit intoGentleman-Programming:mainfrom
Conversation
- Split optional version-stamp commands into separate copy-pasteable blocks (build-only vs build-and-install) so users don't accidentally run both at once - Replace `go build` with `go install` for the install path, so the versioned binary actually lands in $GOPATH/bin instead of the current directory - Add minimum Claude Code CLI version note (>= 2.1.70) to AGENT-SETUP and PLUGINS docs — older versions fail with a schema validation error when adding the marketplace plugin
There was a problem hiding this comment.
Pull request overview
Updates documentation to prevent common install-from-source pitfalls (stale/unversioned binaries) and to clarify a Claude Code CLI minimum version needed for marketplace plugin installation.
Changes:
- Split the “optional version stamp” step into two copy/paste flows:
go build(local binary) vsgo install(installs intoGOBATH/bin/GOBIN). - Add a minimum Claude Code CLI version note (
>= 2.1.70) and the associated error users may see on older versions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/INSTALLATION.md | Clarifies build-vs-install behavior and provides separate version-stamped commands for local testing vs system-wide install. |
| docs/AGENT-SETUP.md | Adds Claude Code CLI minimum version note near marketplace plugin instructions. |
| docs/PLUGINS.md | Adds the same Claude Code CLI minimum version note in the Claude Code plugin section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Alan-TheGentleman
left a comment
Alan-TheGentleman
left a comment
There was a problem hiding this comment.
Buenísimo, @Kevinsillo. Todo impecable.
La separación entre go build (local) y go install (system-wide) era necesaria, antes confundía y los usuarios terminaban con un binario suelto sin instalar. Ahora queda claro qué hace cada uno.
La nota de versión mínima del CLI (>= 2.1.70) con el mensaje de error exacto es un golazo para que nadie pierda tiempo debuggeando.
Dale para adelante.
Summary
go buildfor local testing vsgo installfor system-wide install). Previouslygo build -o engramleft the versioned binary in the current directory without installing it — users who followed the "optional" step ended up with a stale binary in$GOPATH/bin.>= 2.1.70) for the marketplace plugin. Older versions fail withInvalid schema: plugins.0.source: Invalid input.Closes #67
Test plan
go install -ldflagscommand works and places the versioned binary in$GOPATH/bingo build -ldflagscommand builds the binary in the current directory