Skip to content

Fix - ActionNavbar style#2015

Merged
allyoucanmap merged 3 commits intoGeoNode:geonode-homefrom
dsuren1:#117_fix_navbar
Apr 23, 2025
Merged

Fix - ActionNavbar style#2015
allyoucanmap merged 3 commits intoGeoNode:geonode-homefrom
dsuren1:#117_fix_navbar

Conversation

@dsuren1
Copy link
Copy Markdown

@dsuren1 dsuren1 commented Apr 4, 2025

Screenshot

image image

Note

Supporting PR to add menu divider style on MS is here

@dsuren1 dsuren1 added this to the 5.0.0 milestone Apr 4, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap April 4, 2025 14:15
@dsuren1 dsuren1 self-assigned this Apr 4, 2025
@dsuren1
Copy link
Copy Markdown
Author

dsuren1 commented Apr 7, 2025

@allyoucanmap
I believe this should be wrapped in <li> in MenuItem. Your thoughts on this?

if (itm.Component) { 
  return (<li><itm.Component key="{idx}" .../></li>); 
}

@allyoucanmap
Copy link
Copy Markdown

@allyoucanmap I believe this should be wrapped in <li> in MenuItem. Your thoughts on this?

if (itm.Component) { 
  return (<li><itm.Component key="{idx}" .../></li>); 
}

@dsuren1 in some cases you could add multiple children inside the component and for this reason the li was removed (if I remember correctly)

@dsuren1 dsuren1 changed the title #117: Fix - ActionNavbar style 117: Fix - ActionNavbar style Apr 8, 2025
@dsuren1 dsuren1 changed the title 117: Fix - ActionNavbar style Fix - ActionNavbar style Apr 8, 2025
dsuren1 added 2 commits April 9, 2025 11:16
…_navbar

* commit '593a83b341d6b381315809a0fd57f533b155612a':
  Add space to avoid overlapping of resource and pagination (GeoNode#2013)
  Fix - Metadata side panel list style (GeoNode#2012)
  Remove duplicated fullscreen button (GeoNode#2014)
  Add missing translations (GeoNode#2011)
@dsuren1 dsuren1 requested a review from allyoucanmap April 9, 2025 05:56
@allyoucanmap allyoucanmap merged commit b048c3f into GeoNode:geonode-home Apr 23, 2025
giohappy pushed a commit that referenced this pull request May 9, 2025
* replace resources catalog components

* Add missing translations (#2011)

* Remove duplicated fullscreen button (#2014)

* Fix - Metadata side panel list style (#2012)

* Add space to avoid overlapping of resource and pagination (#2013)

* Accordion style update (#2033)

* Fix - ActionNavbar style (#2015)

* Fix - Resource cards are not highlighted when the details are open (#2018)

* Move Permissions to Resource details panel (#2017)

* Update geonode-home to latest MS master (#2041)

* add existing changes

* code refactor

* update unit tests

---------

Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants