Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Greek translations to the GeoNode mapstore client. By adding a new JSON file containing translated messages, the application becomes more accessible and user-friendly for Greek-speaking users, improving their overall experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Greek translations by introducing a new data.el-GR.json file. The translation work is comprehensive. My review focuses on improving consistency and correcting a few typos and potential mistranslations within the new translation file. I've also pointed out some typos in keys that are present in the source files but have been corrected in other language files, suggesting to fix them here for better maintainability.
| "deleteResourceNo": "{count, plural, =1 {Όχι, μην τον διαγράψετε} other {Όχι, μην τους διαγράψετε}}", | ||
| "deleteResourceYes": "Ναι, είμαι σίγουρος", | ||
| "notApproved": "Μη εγκεκριμένο", | ||
| "unpublish": "Αναδημοσίευση", |
There was a problem hiding this comment.
The translation for "unpublish" seems incorrect. "Αναδημοσίευση" means "republish". A more accurate translation for "unpublish" would be "Κατάργηση δημοσίευσης" or "Αποδημοσίευση". This could cause user confusion.
| "unpublish": "Αναδημοσίευση", | |
| "unpublish": "Κατάργηση δημοσίευσης", |
| "clearFilters": "Καθαρισμός φίλτρων", | ||
| "categoriesPlaceholder": "Επιλέξτε κατηγορίες", | ||
| "resourceTypes": "Τύποι πόρων", | ||
| "reasourceType": "Τύπος πόρου", |
There was a problem hiding this comment.
There's a typo in the key reasourceType. It should be resourceType. While this typo exists in the en-US source file and other translation files, several other language files (es-ES, fr-FR, it-IT) have corrected it. For better maintainability and consistency with the corrected files, I suggest using the correct key resourceType.
| "reasourceType": "Τύπος πόρου", | |
| "resourceType": "Τύπος πόρου", |
| "completeUpload": "Ολοκλήρωση ανέβασματος", | ||
| "selectFiles": "Επιλέξτε αρχεία...", | ||
| "addUrl": "Προσθήκη URL...", | ||
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανέβασματων", |
There was a problem hiding this comment.
There appears to be a typo in the word ανέβασματων. The correct genitive plural form is likely ανεβασμάτων.
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανέβασματων", | |
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανεβασμάτων", |
| "transferInProgress": "Μεταφορά σε εξέλιξη", | ||
| "fileExceeds": "Το μέγεθος του αρχείου ξεπερνά τα {limit} MB. Δοκιμάστε με μικρότερο αρχείο.", | ||
| "exceedingFileMsg": "Ορισμένα από τα αρχεία σας ξεπερνούν το όριο ανέβασματος των {limit} MB. Παρακαλώ αφαιρέστε τα από τη λίστα.", | ||
| "cannotPerfomAction": "Αποτυχία εκτέλεσης ενέργειας σε αυτόν τον πόρο.", |
There was a problem hiding this comment.
There's a typo in the key cannotPerfomAction. It should be cannotPerformAction. This typo exists in other files, but for better maintainability, it would be good to use the correct spelling.
| "cannotPerfomAction": "Αποτυχία εκτέλεσης ενέργειας σε αυτόν τον πόρο.", | |
| "cannotPerformAction": "Αποτυχία εκτέλεσης ενέργειας σε αυτόν τον πόρο.", |
| "publishResource": "Δημοσιευμένο", | ||
| "featureResource": "Προτεινόμενο", | ||
| "advertiseResource": "Διαφημισμένο", | ||
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανέβηκε αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", |
There was a problem hiding this comment.
There seems to be a grammatical error in the translation. The word ανέβηκε is a verb in the past tense. The adjectival form ανεβασμένου would be more appropriate here to mean "of the uploaded".
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανέβηκε αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", | |
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανεβασμένου αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", |
| "dataset": "dataset", | ||
| "map": "χάρτης", | ||
| "geostory": "geostory", | ||
| "document": "έγγραφο", | ||
| "dashboard": "πίνακας εργαλείων", | ||
| "mapviewer": "mapviewer", |
There was a problem hiding this comment.
There are some inconsistencies in the translations for technical terms compared to other parts of the file:
dataset: Here it is not translated, but on line 37 it is translated as "Σετ δεδομένων".dashboard: Translated as "πίνακας εργαλείων", but on line 119 it is "Πίνακας ελέγχου".mapviewer: Here it is not translated, but on line 65 (withinviewMapViewer) it is translated as "προβολέας χάρτη".
For consistency throughout the UI, it would be best to use the same translation in all places. Please consider using the already established translations, but in lowercase as is the convention for these specific keys.
| "dataset": "dataset", | |
| "map": "χάρτης", | |
| "geostory": "geostory", | |
| "document": "έγγραφο", | |
| "dashboard": "πίνακας εργαλείων", | |
| "mapviewer": "mapviewer", | |
| "dataset": "σετ δεδομένων", | |
| "map": "χάρτης", | |
| "geostory": "geostory", | |
| "document": "έγγραφο", | |
| "dashboard": "πίνακας ελέγχου", | |
| "mapviewer": "προβολέας χάρτη", |
| } | ||
| } | ||
| } | ||
|
No newline at end of file |
There was a problem hiding this comment.
This line contains trailing whitespace and should be removed.
1 participant
I am working to update GeoNode Greek translations.