Backport Greek gn-translations to 5.0.x#2439
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Greek language support to the mapstore client by adding a new translation file. This enhances the user experience for Greek-speaking users of GeoNode. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Greek translation file (data.el-GR.json) for the MapStore client. The new file provides translations for various UI elements. My review focuses on the correctness and consistency of the new translation file.
I've found a few potential issues:
- Some minor typos and grammatical errors in the Greek translations.
- An extra translation key that is not present in other language files, which might be an error.
- A minor formatting issue at the end of the file.
I've added specific comments with suggestions for these points. Overall, this is a great addition, and with these small fixes, it will be ready to merge.
| "datasetTitle": "Τίτλος dataset", | ||
| "name": "Όνομα", | ||
| "type": "Τύπος", | ||
| "typeText": "Πληκτρολογήστε κείμενο στα {lang} ...", |
There was a problem hiding this comment.
This translation key typeText is not present in the reference English translation file (data.en-US.json) or other language files. Please verify if this key should be here. If it's not used, it should be removed to maintain consistency across translation files.
| "completeUpload": "Ολοκλήρωση ανέβασματος", | ||
| "selectFiles": "Επιλέξτε αρχεία...", | ||
| "addUrl": "Προσθήκη URL...", | ||
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανέβασματων", |
There was a problem hiding this comment.
There appears to be a typo in the translation. The word "ανέβασματων" should likely be "ανεβασμάτων".
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανέβασματων", | |
| "duplicateUrl": "Αυτό το URL υπάρχει ήδη στη λίστα ανεβασμάτων", |
| "publishResource": "Δημοσιευμένο", | ||
| "featureResource": "Προτεινόμενο", | ||
| "advertiseResource": "Διαφημισμένο", | ||
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανέβηκε αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", |
There was a problem hiding this comment.
There seems to be a grammatical error in the translation. The word "ανέβηκε" (verb) should probably be "ανεβασμένου" (participle) to correctly modify "αρχείου".
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανέβηκε αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", | |
| "preserveUploadedMetadataTooltip": "Διατήρηση του ανεβασμένου αρχείου ISO μεταδεδομένων αντί να δημιουργηθεί νέο", |
| "rangeNotSupportedForDate": "Το εύρος δεν υποστηρίζεται για τον τύπο ημερομηνίας: {propName}", | ||
| "enumNotSupportedForDate": "Οι επιλογές περιορισμών δεν υποστηρίζονται για τον τύπο ημερομηνίας: {propName}", | ||
| "schemaParseError": "Σφάλμα κατά την ανάλυση του schema", | ||
| "enumMustBeString": "Οι επιλογές πρέπει να είναι πίνακας κειμένων: {propName}. Οι επιλογές μετατρέπονται σε κείμενο", |
There was a problem hiding this comment.
The translation for "strings" (plural) is "κείμενο" (singular "text"). For better accuracy and consistency with other translations of "string" in this file (e.g., line 7), consider using "συμβολοσειρές" (strings).
| "enumMustBeString": "Οι επιλογές πρέπει να είναι πίνακας κειμένων: {propName}. Οι επιλογές μετατρέπονται σε κείμενο", | |
| "enumMustBeString": "Οι επιλογές πρέπει να είναι πίνακας κειμένων: {propName}. Οι επιλογές μετατρέπονται σε συμβολοσειρές", |
| } | ||
| } | ||
| } | ||
|
No newline at end of file |
There was a problem hiding this comment.
This file has trailing whitespace on the last line and is missing a final newline character. It's best practice for text files to end with a single newline and have no trailing whitespace.
1 participant
No description provided.