Skip to content

[Fixes #2477] Make TIFF the first and default download format#2478

Merged
giohappy merged 1 commit intomasterfrom
change_download_formats_order
Mar 31, 2026
Merged

[Fixes #2477] Make TIFF the first and default download format#2478
giohappy merged 1 commit intomasterfrom
change_download_formats_order

Conversation

@giohappy
Copy link
Copy Markdown

No description provided.

@giohappy giohappy requested a review from allyoucanmap March 31, 2026 09:02
@giohappy giohappy linked an issue Mar 31, 2026 that may be closed by this pull request
@giohappy giohappy merged commit 8212e17 into master Mar 31, 2026
1 check passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorders the download formats in localConfig.json to prioritize image/tiff over application/arcgrid across several plugin configurations. Feedback indicates that if the objective is to make TIFF the absolute first format, it should be moved above GeoJSON, which currently remains at the top of the list.

Comment on lines +932 to 938
"name": "image/tiff",
"label": "TIFF",
"type": "raster",
"validServices": [
"wps"
]
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request title states that TIFF should be the first and default download format. However, in the current configuration, application/json (GeoJSON) remains at the top of the formats list (index 0), making TIFF the second item overall.

If the requirement is to have TIFF as the absolute first format in the list, it should be moved to the top of the array, above GeoJSON. If the intention was specifically to make it the default for raster layers, then the current change is correct as it is now the first raster format in the list. This observation applies to all three occurrences of the LayerDownload plugin configuration in this file.

@github-actions
Copy link
Copy Markdown

The backport to 5.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0.x 5.0.x
# Navigate to the new working tree
cd .worktrees/backport-5.0.x
# Create a new branch
git switch --create backport-2478-to-5.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8212e17d9ced3e9aef8b5537c52c3fd169976d41
# Push it to GitHub
git push --set-upstream origin backport-2478-to-5.0.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0.x

Then, create a pull request where the base branch is 5.0.x and the compare/head branch is backport-2478-to-5.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make TIFF the first and default download format

2 participants