Fix #2480 Permission entry is disabled for current user .#2481
Merged
subashtiwari1010 merged 4 commits intoGeoNode:masterfrom Apr 1, 2026
Merged
Fix #2480 Permission entry is disabled for current user .#2481subashtiwari1010 merged 4 commits intoGeoNode:masterfrom
subashtiwari1010 merged 4 commits intoGeoNode:masterfrom
Conversation
… update the submodule for related changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MapStore2 subproject and introduces logic to disable permission settings for the current user within the resource sharing interface. Changes include passing the current user object through the component hierarchy, updating the permissionsCompactToLists utility to determine a disabled state, and adding corresponding unit tests. Review feedback suggests refining the disabling logic in ResourceUtils.js to ensure it applies to all permission levels for the current user and includes a safety check for the user ID, alongside a minor formatting correction in GeoLimits.jsx.
geonode_mapstore_client/client/js/plugins/ResourceDetails/components/GeoLimits.jsx
Outdated
Show resolved
Hide resolved
allyoucanmap
requested review from
subashtiwari1010
and removed request for
allyoucanmap
anup39
changed the title
|
@anup39 please fix the merge conflict. |
Member
Author
|
@subashtiwari1010 okay |
…nto fix_permission_disable_2480
Member
Author
Done. |
subashtiwari1010
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add following :
permission_test.mp4