Skip to content

[Fixes #13100] Fixing permissions bug of the delete_thumbnail endpoint#13101

Merged
mattiagiupponi merged 2 commits intomasterfrom
ISSUE_13100
Apr 15, 2025
Merged

[Fixes #13100] Fixing permissions bug of the delete_thumbnail endpoint#13101
mattiagiupponi merged 2 commits intomasterfrom
ISSUE_13100

Conversation

@Gpetrak
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak commented Apr 15, 2025

This PR fixes this issue: #13100

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added the bug label Apr 15, 2025
@Gpetrak Gpetrak added this to the 5.0.0 milestone Apr 15, 2025
@Gpetrak Gpetrak self-assigned this Apr 15, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 15, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.81%. Comparing base (de19f5e) to head (1c17dd4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13101   +/-   ##
=======================================
  Coverage   67.81%   67.81%           
=======================================
  Files         979      979           
  Lines       57453    57465   +12     
  Branches     6631     6632    +1     
=======================================
+ Hits        38962    38972   +10     
- Misses      16923    16926    +3     
+ Partials     1568     1567    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy removed their request for review April 15, 2025 16:08
@mattiagiupponi mattiagiupponi merged commit 8677a7f into master Apr 15, 2025
17 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_13100 branch April 15, 2025 16:20
@mattiagiupponi mattiagiupponi removed this from the 5.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permissions bug of the delete_thumbnail endpoint Implement the API thumbnail endpoint method to delete the thumbnail for a resource

2 participants