Implement customizable serialization, make vibe-d:data optional#59
Implement customizable serialization, make vibe-d:data optional#59
Conversation
|
This is nice. What's the failure in Agora? |
|
Memory corruption because things are moved |
Geod24
force-pushed
the
serialization
branch
2 times, most recently
from
3ba11b0 to
0e932e2
Compare
Codecov Report
@@ Coverage Diff @@
## v0.x.x #59 +/- ##
==========================================
+ Coverage 93.08% 93.27% +0.19%
==========================================
Files 3 4 +1
Lines 665 684 +19
==========================================
+ Hits 619 638 +19
Misses 46 46
Continue to review full report at Codecov.
|
Geod24
force-pushed
the
serialization
branch
2 times, most recently
from
f427b9f to
fd57529
Compare
|
This is ready |
Strange random failure on ldc. I wonder if we have a bug somewhere.. |
|
Hum, I see it in Agora when I switch to the Serializer. Will look deeper into it. |
| Serialize arbitrary data to / from JSON | ||
|
|
||
| This is the default serializer used by LocalRest, when none is provided. | ||
| It is a template so that LocalRest does not import Vibe.d if not used. |
There was a problem hiding this comment.
Won't it be imported regardless when -unittest is passed in the client code? Because the unittest block below will instantiate this template.
There was a problem hiding this comment.
Unittests in non-root modules should not be parsed
There was a problem hiding this comment.
hmm.. this is when using dub only, right?
There was a problem hiding this comment.
No it's a DMD behavior, see discussions here: dlang/dmd#10937
There was a problem hiding this comment.
Ah interesting. I know Walter implemented the "don't parse unittest blocks when -unittest is not passed", but I didn't know about this other feature.
AndrejMitrovic
left a comment
AndrejMitrovic
left a comment
There was a problem hiding this comment.
LGTM. Just had a few questions.
This will be used by Agora, for types that are not JSON-serializable.
2 participants
This will be used by Agora, for types that are not JSON-serializable.
This is marked as a draft ATM, because it doesn't pass the tests with Agora.