Skip to content

fix(ColorMap): remove obsolete scalar_range and redundant points RPCs #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 4 commits into from
Feb 19, 2026
Merged

fix(ColorMap): remove obsolete scalar_range and redundant points RPCs #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
162d515
fix(ColorMap): remove obsolete scalar_range and redundant points RPCs
SpliiT Feb 18, 2026
88c98f0
Apply prepare changes
SpliiT Feb 18, 2026
e508e3e
update tests
SpliiT Feb 19, 2026
e0a7f8b
Apply prepare changes
SpliiT Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 0 additions & 184 deletions opengeodeweb_viewer_schemas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,6 @@
"cells": {
"attribute": {
"cell": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.cells.attribute.cell.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.cells.attribute.cell.name",
"rpc": "name",
Expand Down Expand Up @@ -113,29 +90,6 @@
}
},
"vertex": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.cells.attribute.vertex.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.cells.attribute.vertex.name",
"rpc": "name",
Expand Down Expand Up @@ -283,29 +237,6 @@
}
},
"vertex": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.edges.attribute.vertex.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.edges.attribute.vertex.name",
"rpc": "name",
Expand Down Expand Up @@ -450,29 +381,6 @@
"points": {
"attribute": {
"vertex": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.points.attribute.vertex.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.points.attribute.vertex.name",
"rpc": "name",
Expand Down Expand Up @@ -692,29 +600,6 @@
"polygons": {
"attribute": {
"polygon": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.polygons.attribute.polygon.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.polygons.attribute.polygon.name",
"rpc": "name",
Expand Down Expand Up @@ -769,29 +654,6 @@
}
},
"vertex": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.polygons.attribute.vertex.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.polygons.attribute.vertex.name",
"rpc": "name",
Expand Down Expand Up @@ -917,29 +779,6 @@
"polyhedra": {
"attribute": {
"polyhedron": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.polyhedra.attribute.polyhedron.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.polyhedra.attribute.polyhedron.name",
"rpc": "name",
Expand Down Expand Up @@ -994,29 +833,6 @@
}
},
"vertex": {
"scalar_range": {
"$id": "opengeodeweb_viewer.mesh.polyhedra.attribute.vertex.scalar_range",
"rpc": "scalar_range",
"type": "object",
"properties": {
"id": {
"type": "string",
"minLength": 1
},
"minimum": {
"type": "number"
},
"maximum": {
"type": "number"
}
},
"required": [
"id",
"minimum",
"maximum"
],
"additionalProperties": false
},
"name": {
"$id": "opengeodeweb_viewer.mesh.polyhedra.attribute.vertex.name",
"rpc": "name",
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,3 @@ wslink==1.12.4
yarl>=1
# via aiohttp

opengeodeweb-microservice==1.*,>=1.0.14
13 changes: 0 additions & 13 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/cell/cells_attribute_cell_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,6 @@ def setMeshCellsCellAttribute(self, rpc_params: RpcParams) -> None:
params = schemas.Name.from_dict(rpc_params)
self.displayAttributeOnCells(params.id, params.name)

@exportRpc(
mesh_cells_attribute_cell_prefix
+ mesh_cells_attribute_cell_schemas_dict["scalar_range"]["rpc"]
)
def setMeshCellsCellScalarRange(self, rpc_params: RpcParams) -> None:
validate_schema(
rpc_params,
self.mesh_cells_attribute_cell_schemas_dict["scalar_range"],
self.mesh_cells_attribute_cell_prefix,
)
params = schemas.ScalarRange.from_dict(rpc_params)
self.displayScalarRange(params.id, params.minimum, params.maximum)

@exportRpc(
mesh_cells_attribute_cell_prefix
+ mesh_cells_attribute_cell_schemas_dict["color_map"]["rpc"]
Expand Down
1 change: 0 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/cells/attribute/cell/schemas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
from .scalar_range import *
from .name import *
from .color_map import *
22 changes: 0 additions & 22 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/cell/schemas/scalar_range.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/cell/schemas/scalar_range.py
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/vertex/cells_attribute_vertex_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,6 @@ def setMeshCellsVertexName(self, rpc_params: RpcParams) -> None:
params = schemas.Name.from_dict(rpc_params)
self.displayAttributeOnVertices(params.id, params.name)

@exportRpc(
mesh_cells_attribute_vertex_prefix
+ mesh_cells_attribute_vertex_schemas_dict["scalar_range"]["rpc"]
)
def setMeshCellsVertexScalarRange(self, rpc_params: RpcParams) -> None:
validate_schema(
rpc_params,
self.mesh_cells_attribute_vertex_schemas_dict["scalar_range"],
self.mesh_cells_attribute_vertex_prefix,
)
params = schemas.ScalarRange.from_dict(rpc_params)
self.displayScalarRange(params.id, params.minimum, params.maximum)

@exportRpc(
mesh_cells_attribute_vertex_prefix
+ mesh_cells_attribute_vertex_schemas_dict["color_map"]["rpc"]
Expand Down
1 change: 0 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/cells/attribute/vertex/schemas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
from .scalar_range import *
from .name import *
from .color_map import *
22 changes: 0 additions & 22 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/vertex/schemas/scalar_range.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/opengeodeweb_viewer/rpc/mesh/cells/attribute/vertex/schemas/scalar_range.py
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/opengeodeweb_viewer/rpc/mesh/edges/attribute/vertex/edges_attribute_vertex_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,6 @@ def setMeshEdgesVertexName(self, rpc_params: RpcParams) -> None:
params = schemas.Name.from_dict(rpc_params)
self.displayAttributeOnVertices(params.id, params.name)

@exportRpc(
mesh_edges_attribute_vertex_prefix
+ mesh_edges_attribute_vertex_schemas_dict["scalar_range"]["rpc"]
)
def setMeshEdgesVertexScalarRange(self, rpc_params: RpcParams) -> None:
validate_schema(
rpc_params,
self.mesh_edges_attribute_vertex_schemas_dict["scalar_range"],
self.mesh_edges_attribute_vertex_prefix,
)
params = schemas.ScalarRange.from_dict(rpc_params)
self.displayScalarRange(params.id, params.minimum, params.maximum)

@exportRpc(
mesh_edges_attribute_vertex_prefix
+ mesh_edges_attribute_vertex_schemas_dict["color_map"]["rpc"]
Expand Down
1 change: 0 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/edges/attribute/vertex/schemas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
from .scalar_range import *
from .name import *
from .color_map import *
Loading