iOS Safari hangs (or crashes) when using `js.Browser.window.open()` from `NG.passportHelper()`

[ninjamuffin99]

seems like when opening a page via an asyncronous call, iOS Safari does NOT let you call window.open()
https://stackoverflow.com/questions/20696041/window-openurl-blank-not-working-on-imac-safari

expected behaviour: passport login screen opens in new tab when requestLogin() is called

actual behaviour: on iOS Safari (and potentially any iOS web browser?), calling requestLogin() freezes the game.

[ninjamuffin99]

in the readme.md at the bottom there's allow synchronous use of http requests there, and implementing that might come in handy 🤔

[Geokureli]

If I understand correctly, it's always wise to open the passport window via a button click, this is what I do in all my projects, even on non-safari browsers I had issues where popups were blocked if they were not triggered within some kind of user input event.

I also think it's generally good UX to prompt the user saying "Do you want to log in to newgrounds? Y/N" before popping up the login window. here is an example. I checked this on Safari OSX and iOS, and had no issues

[ninjamuffin99]

I suppose the specific instance is relevant even when specifically triggered via user input. When I press "login" on safari, it calls NG.core.requestLogin() , which under the hood, calls calls.app.startSession(true) which does an AsyncNGcall.send() under the hood since it's on JS. And since it's on JS, by default it's running Asynchronously.

SO, from within the async function, onSessionRecieve callback is called, which is what calls passportHandler, which is what calls js.Browser.window.open(url, window);. That essentially gets called FROM the async function, rather than something like being called from a .then() function. Very subtle difference, but affects SPECIFICALLY iOS version of Safari, even when you explicitly call it via a user input. It DOES accept the input all fine and perfect, but it simply doesn't open the window since Safari doesn't allow/like new tabs to get opened from anything other than the main "thread".

[Geokureli]

When calling requestLogin you can pass in a custom passportHandler arg, which is called after the passport url is determined, once the passportHandler is called you show the buttons, which call NG.core.openPassportUrl(); on YES and NG.core.cancelLoginRequest(); on NO.

Here's an example. Note: In my example I ignore the arg passed to the passportHandler, this arg is the url, but you can ignore this since openPassportUrl already opens this, alternatively you can open the url yourself and check the status of the session to see if it has been accepted