Open
Conversation
f-lab-jake
requested changes
Dec 21, 2023
Collaborator
f-lab-jake
left a comment
There was a problem hiding this comment.
전체적으로 안좋은 패턴들이 많이 들어가있는데요.
코드의 많은 부분들이 서로서로 의존하고 있습니다.
어느 부분인지 아시겠나요? 그리고 이 코드에서 스스로 아쉬운점이 느껴지는게 있다면 한번 설명해봅시다.
Owner
Author
|
|
Collaborator
요부분은 코드를 좀더 잘 짤순있겠지만, 초기화 로직이라서 그렇게 문제되진 않습니다. 초기화하고 안건드리고 있으니까요.
요부분은 정확하게 보았습니다. 비슷하게, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제 출처: https://www.acmicpc.net/problem/1240