Added a remove method on the compare control.#2
Draft
StephaneAlie wants to merge 2 commits intomasterfrom
Draft
Conversation
dalie
reviewed
Dec 9, 2019
| }, | ||
| "dependencies": { | ||
| "@mapbox/mapbox-gl-sync-move": "^0.2.0" | ||
| "@mapbox/mapbox-gl-sync-move": "^0.3.0" |
Member
There was a problem hiding this comment.
I think they fixed some things in 0.3.0 that we need to behave correctly.
Member
Author
There was a problem hiding this comment.
That new version exposes a method to clear the sync.
| var compare = new mapboxgl.Compare(a, b, container); | ||
|
|
||
| t.notOk(!!a.getContainer().style.clip, 'Map A is not clipped'); | ||
| t.ok(!!a.getContainer().style.clip, 'Map A is clipped'); |
Member
There was a problem hiding this comment.
Why did the result of this test change?
Member
Author
There was a problem hiding this comment.
Someone changed the behavior and forgot to update the test, it was failing as is, figured I'd fix it.
AnthonyMacKinnon
approved these changes
Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for review.