Conversation
swamp-agr
approved these changes
Apr 20, 2026
Collaborator
There was a problem hiding this comment.
Thank you for looking into this. I read through the code and understood how you achieved compatibility. Also documentation helps us to clean it later on. For now it's good as it is.
CI could be fixed separately. It is failing for unrelated reasons. Most likely, due to Cabal major version bump.
Collaborator
|
Let fix CI separately. Merging and releasing this patch! Thanks! |
maksbotan
added a commit
to biocad/openapi3
that referenced
this pull request
Apr 22, 2026
Port of swagger2 PR at GetShopTV/swagger2#262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #261, although I really don't like the way I implemented it. Ideally, we want an upstream PR to
insert-ordered-containersthat restores old behavior (in a separate submodule, probably).