Add i18n to emoji picker #296
Conversation
size-limit report 📦
|
mahboubii
left a comment
mahboubii
left a comment
There was a problem hiding this comment.
LGTM, Could you also add some tests for this?
@mahboubii will do :) |
|
@arnautov-anton @mahboubii Finally added those tests to EmojiPicker + StatusUpdateForm. I have only tested that the props are correctly passed down. Could you please review these changes? Thank you |
Use PropsWithChildren Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
Use PropsWithChildren Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
Use default props Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
|
LGTM. 👍 |
src/i18n/en.json
Outdated
| "Smileys & Emotion": "Smileys & Emotion", | ||
| "Smileys & People": "Smileys & People", |
There was a problem hiding this comment.
is this change necessary to adapt to emoji-mart default set?
There was a problem hiding this comment.
@mahboubii the intention was not only to align it with the npm package, but also with the key under which it is stored in the I18n object (categories.people). Do you prefer me to revert this change?
There was a problem hiding this comment.
reverting back to Smileys & Emotion
Co-authored-by: Amin Mahboubi <amin@getstream.io>
Co-authored-by: Amin Mahboubi <amin@getstream.io>
…d-i18n-to-EmojiPicker
Adding optional
emojiI18nprop toStatusUpdateFormPropsin order the user can pass custom strings / translations to EmojiPicker.