Skip to content

Expose completion callback for audio recording #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 1 commit into from
Mar 26, 2026
Merged

Expose completion callback for audio recording #6290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stream-chat-android-compose/api/stream-chat-android-compose.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5025,7 +5025,8 @@ public final class io/getstream/chat/android/compose/viewmodel/messages/MessageC
public static synthetic fun buildNewMessage$default (Lio/getstream/chat/android/compose/viewmodel/messages/MessageComposerViewModel;Ljava/lang/String;Ljava/util/List;ILjava/lang/Object;)Lio/getstream/chat/android/models/Message;
public final fun cancelRecording ()V
public final fun clearData ()V
public final fun completeRecording ()V
public final fun completeRecording (Lkotlin/jvm/functions/Function1;)V
public static synthetic fun completeRecording$default (Lio/getstream/chat/android/compose/viewmodel/messages/MessageComposerViewModel;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)V
public final fun createPoll (Lio/getstream/chat/android/models/PollConfig;)V
public final fun dismissMessageActions ()V
public final fun getAlsoSendToChannel ()Lkotlinx/coroutines/flow/MutableStateFlow;
Expand Down
4 changes: 3 additions & 1 deletion ...ain/java/io/getstream/chat/android/compose/viewmodel/messages/MessageComposerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import io.getstream.chat.android.ui.common.state.messages.Reply
import io.getstream.chat.android.ui.common.state.messages.composer.MessageComposerState
import io.getstream.chat.android.ui.common.state.messages.composer.ValidationError
import io.getstream.chat.android.ui.common.utils.typing.TypingUpdatesBuffer
import io.getstream.result.Result
import io.getstream.result.call.Call
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.MutableStateFlow
Expand Down Expand Up @@ -273,7 +274,8 @@ public class MessageComposerViewModel(

public fun toggleRecordingPlayback(): Unit = messageComposerController.toggleRecordingPlayback()

public fun completeRecording(): Unit = messageComposerController.completeRecording()
public fun completeRecording(onComplete: ((Result<Attachment>) -> Unit)? = null): Unit =
messageComposerController.completeRecording(onComplete)

public fun pauseRecording(): Unit = messageComposerController.pauseRecording()

Expand Down
19 changes: 15 additions & 4 deletions ...o/getstream/chat/android/ui/common/feature/messages/composer/MessageComposerController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,12 +922,23 @@ public class MessageComposerController(
}

/**
* Completes audio recording and moves [MessageComposerState.recording] state to [RecordingState.Complete].
* Also, it wil update [MessageComposerState.attachments] list.
* Completes audio recording and updates the [MessageComposerState.attachments] list.
*
* @param onComplete Optional callback invoked with the result of the recording once the recording has been
* finalized. On success, the recorded [Attachment] is added to [selectedAttachments] before the callback
* is invoked, so callers can safely build and send a message using the received attachment.
*/
public fun completeRecording() {
public fun completeRecording(onComplete: ((Result<Attachment>) -> Unit)? = null) {
scope.launch {
audioRecordingController.completeRecording()
if (onComplete != null) {
val result = audioRecordingController.completeRecordingSync()
if (result is Result.Success) {
selectedAttachments.value += result.value
}
onComplete(result)
} else {
audioRecordingController.completeRecording()
}
}
}

Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-ui-components/api/stream-chat-android-ui-components.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4518,7 +4518,8 @@ public final class io/getstream/chat/android/ui/viewmodel/messages/MessageCompos
public static synthetic fun buildNewMessage$default (Lio/getstream/chat/android/ui/viewmodel/messages/MessageComposerViewModel;Ljava/lang/String;Ljava/util/List;ILjava/lang/Object;)Lio/getstream/chat/android/models/Message;
public final fun cancelRecording ()V
public final fun clearData ()V
public final fun completeRecording ()V
public final fun completeRecording (Lkotlin/jvm/functions/Function1;)V
public static synthetic fun completeRecording$default (Lio/getstream/chat/android/ui/viewmodel/messages/MessageComposerViewModel;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)V
public final fun createPoll (Lio/getstream/chat/android/models/PollConfig;)V
public final fun dismissMessageActions ()V
public final fun dismissSuggestionsPopup ()V
Expand Down
4 changes: 3 additions & 1 deletion ...c/main/kotlin/io/getstream/chat/android/ui/viewmodel/messages/MessageComposerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import io.getstream.chat.android.ui.common.state.messages.MessageMode
import io.getstream.chat.android.ui.common.state.messages.Reply
import io.getstream.chat.android.ui.common.state.messages.composer.MessageComposerState
import io.getstream.chat.android.ui.common.state.messages.composer.ValidationError
import io.getstream.result.Result
import io.getstream.result.call.Call
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.MutableStateFlow
Expand Down Expand Up @@ -250,7 +251,8 @@ public class MessageComposerViewModel(

public fun toggleRecordingPlayback(): Unit = messageComposerController.toggleRecordingPlayback()

public fun completeRecording(): Unit = messageComposerController.completeRecording()
public fun completeRecording(onComplete: ((Result<Attachment>) -> Unit)? = null): Unit =
messageComposerController.completeRecording(onComplete)

public fun pauseRecording(): Unit = messageComposerController.pauseRecording()

Expand Down
Loading