Fix wrong message selected on quoted message long click by gpunto · Pull Request #6292 · GetStream/stream-chat-android

gpunto · 2026-03-25T13:51:41Z

Goal

When it comes to quoted messages, we currently have this behavior:

If a user long presses on the quoting message, the long-press menu refers to that message
If a user long presses on the quoted message preview, the long-press menu refer to the original message

The second behavior is wrong, as the intent of the user is acting on the quoting message, not on previewed one.

Implementation

Pass replyMessage when not-null, which is the quoting message

🎨 UI Changes

Before	After
Screen_recording_20260325_140152.webm	Screen_recording_20260325_145150.webm

Testing

You can test the behavior in the sample, e.g. by long pressing on the quoting/quoted message and verifying that the action you take refers always to the quoting message.

Summary by CodeRabbit

Bug Fixes
- Enhanced long-click interaction handling for quoted messages to accurately identify and reference the appropriate message context, improving the precision of message-related actions when users interact with quoted content in conversations.

github-actions · 2026-03-25T13:51:56Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

github-actions · 2026-03-25T13:56:56Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-chat-android-client	5.26 MB	5.26 MB	🟢
stream-chat-android-offline	5.49 MB	5.49 MB	🟢
stream-chat-android-ui-components	10.63 MB	10.63 MB	🟢
stream-chat-android-compose	12.86 MB	12.86 MB	🟢

coderabbitai · 2026-03-25T13:58:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ec11ca14-6748-4d6f-991c-b1bd4daf9ea3

📥 Commits

Reviewing files that changed from the base of the PR and between 6c63890 and ea272ea.

📒 Files selected for processing (1)

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/QuotedMessage.kt

Walkthrough

The QuotedMessage component's long-click handler now passes replyMessage ?: message to the onLongItemClick callback instead of always passing message, while the regular click handler behavior remains unchanged.

Changes

Cohort / File(s)	Summary
Quoted Message Long-Click Handler `stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/QuotedMessage.kt`	Modified long-click handler to pass `replyMessage ?: message` instead of `message` to `onLongItemClick` callback; click handler unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny hop, a clever switch,
When long-click calls, which message rich?
Now replyMessage takes the stage,
Or falls back gracefully, page by page,
One line changed, but oh so bright! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main bug fix: correcting the wrong message selection behavior when long-clicking a quoted message.
Description check	✅ Passed	The description covers Goal, Implementation, and UI Changes with before/after videos. However, Testing section lacks detail and the Contributor/Reviewer Checklists are not completed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch bug/quoted-message-long-click

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-03-25T13:59:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stream-public-bot · 2026-03-26T19:12:48Z

🚀 Available in v6.36.0

* Improve `Message.createdLocallyAt` creation logic using estimated server time (#6199) * Fix createdLocallyAt using NTP-style server clock offset estimation Co-Authored-By: Claude <noreply@anthropic.com> * Pr remarks * Adjust thread message createdLocallyAt. * Ensure exceedsSyncThreshold is compared against estimated server time (where applicable). * Add max allowed offset. --------- Co-authored-by: Claude <noreply@anthropic.com> * [skip ci] Update SDK sizes * Update README cover image (#6282) * Fix XML image flicker caused by `interceptorCoroutineContext(Dispatchers.IO)` (#6284) Co-authored-by: Claude <noreply@anthropic.com> * [skip ci] Update SDK sizes * AUTOMATION: Version Bump * Fix race condition in plugin resolution during disconnect (#6269) * Update `DependencyResolverTest` to verify error handling when dependency resolution races with disconnection. * Prevent race conditions during disconnects in `ChatClient`. * Handle unresolvable attachments in picker (#6285) - Update `StorageHelper` and `AttachmentMetaDataMapper` to safely handle cases where content URIs (e.g. cloud-backed files) cannot be opened. - Introduce `hasUnresolvedAttachments` state in `AttachmentsPickerViewModel` to track failed attachment resolutions. - Show a toast message in both View-based and Compose attachment pickers when files are unavailable and need to be downloaded to the device. - Add `clearUnresolvedAttachments` to reset the error state after it has been consumed by the UI. - Add unit tests for unresolved attachment scenarios in `AttachmentsPickerViewModelTest`. * [skip ci] Update SDK sizes * Fix wrong message selected on quoted message long click (#6292) * Use type-specific attachment URL fields and deprecate `imagePreviewUrl` (#6280) * Deprecate imagePreviewUrl and use type-specific attachment URL fields Co-Authored-By: Claude <noreply@anthropic.com> * Extract common extensions. --------- Co-authored-by: Claude <noreply@anthropic.com> * Expose optional completion callback for audio recording (#6290) Co-authored-by: Claude <noreply@anthropic.com> * AUTOMATION: Version Bump * AUTOMATION: Clean Detekt Baseline Files (#6299) Co-authored-by: adasiewiczr <17440581+adasiewiczr@users.noreply.github.com> * Add support for intercepting CDN file requests (#6295) * Add new CDN contract. * Add CDN for document files. * Add CDN support for downloading attachments. * Deprecate current CDN methods. * Add progress indicator snackbar. * Add useDocumentGView config flag. * Add file sharing cache handling. * Add file sharing cache handling. * Remove CDNResponse.kt * Add tests * PR remarks * [skip ci] Update SDK sizes * Post-merge clean-up. * Post-merge clean-up. * ApiDump. * Improve attachment URI resolution and error handling in `AttachmentsPickerViewModel` and `AttachmentStorageHelper`. - Add `isUriResolvable` to `StorageHelper` to verify if a content URI can be opened for reading. - Implement `partitionResolvable` in `AttachmentStorageHelper` to separate metadata based on URI accessibility. - Update `AttachmentsPickerViewModel.resolveAndSubmitUris` to exclude inaccessible URIs (e.g., undownloaded cloud files) from the submission. - Ensure `hasUnresolvedAttachments` is correctly set when URIs are inaccessible, independent of file type support. - Add unit tests in `AttachmentStorageHelperTest` and `AttachmentsPickerViewModelTest` to verify partitioning logic and view model state updates. * Handle unresolvable attachments in XML * apiDump. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: André Mion <andremion@gmail.com> Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com> Co-authored-by: stream-pr-merger[bot] <117762243+stream-pr-merger[bot]@users.noreply.github.com> Co-authored-by: adasiewiczr <17440581+adasiewiczr@users.noreply.github.com>

Fix wrong message selected on quoted message long click

ea272ea

gpunto added the pr:bug Bug fix label Mar 25, 2026

gpunto marked this pull request as ready for review March 25, 2026 13:53

gpunto requested a review from a team as a code owner March 25, 2026 13:53

gpunto marked this pull request as draft March 25, 2026 14:02

gpunto marked this pull request as ready for review March 25, 2026 14:14

gpunto mentioned this pull request Mar 25, 2026

Remove click lambdas from quoted message parameters #6293

Merged

andremion approved these changes Mar 25, 2026

View reviewed changes

andremion merged commit a7b8580 into develop Mar 25, 2026
17 of 18 checks passed

andremion deleted the bug/quoted-message-long-click branch March 25, 2026 16:14

stream-public-bot added the released Included in a release label Mar 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wrong message selected on quoted message long click#6292

Fix wrong message selected on quoted message long click#6292
andremion merged 1 commit intodevelopfrom
bug/quoted-message-long-click

gpunto commented Mar 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

coderabbitai Bot commented Mar 25, 2026

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Uh oh!

Uh oh!

stream-public-bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gpunto commented Mar 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

🎨 UI Changes

Testing

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

github-actions Bot commented Mar 25, 2026

SDK Size Comparison 📏

Uh oh!

coderabbitai Bot commented Mar 25, 2026

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Quality Gate passed

Uh oh!

Uh oh!

stream-public-bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gpunto commented Mar 25, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Mar 25, 2026 •

edited

Loading