Skip to content

Fix offline persisted drafts not cleared on logout #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 1 commit into from
Apr 16, 2026
Merged

Fix offline persisted drafts not cleared on logout #6372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stream-chat-android-offline/api/stream-chat-android-offline.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public final class io/getstream/chat/android/offline/repository/domain/message/i
public final class io/getstream/chat/android/offline/repository/domain/message/internal/MessageDao_Impl : io/getstream/chat/android/offline/repository/domain/message/internal/MessageDao {
public fun <init> (Landroidx/room/RoomDatabase;)V
public fun deleteAll (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
public fun deleteAllDrafts (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
public fun deleteAttachments (Ljava/util/List;)V
public fun deleteAttachmentsChunked (Ljava/util/List;)V
public fun deleteChannelMessagesBefore (Ljava/lang/String;Ljava/util/Date;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
Expand Down
1 change: 1 addition & 0 deletions ...ream/chat/android/offline/repository/domain/message/internal/DatabaseMessageRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ internal class DatabaseMessageRepository(
replyMessageCache.evictAll()
dbMutex.withLock {
messageDao.deleteAll()
messageDao.deleteAllDrafts()
replyMessageDao.deleteAll()
}
}
Expand Down
3 changes: 3 additions & 0 deletions ...n/java/io/getstream/chat/android/offline/repository/domain/message/internal/MessageDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ internal interface MessageDao {
@Query("DELETE FROM $MESSAGE_ENTITY_TABLE_NAME")
suspend fun deleteAll()

@Query("DELETE FROM $DRAFT_MESSAGE_ENTITY_TABLE_NAME")
suspend fun deleteAllDrafts()

private companion object {
private const val SQLITE_MAX_VARIABLE_NUMBER: Int = 999
private const val NO_LIMIT: Int = -1
Expand Down
22 changes: 22 additions & 0 deletions ...line/src/test/java/io/getstream/chat/android/offline/repository/MessageRepositoryTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,26 @@ internal class MessageRepositoryTests {
// then
verify(messageDao).deleteMessages(messageIds)
}

@Test
fun `when calling clear, then all related tables are cleared`() = runTest(testDispatcher) {
// given
val repository = DatabaseMessageRepository(
this,
messageDao,
replyMessageDao,
pollDao,
::randomUser,
randomUser(id = "currentUserId"),
emptySet(),
)

// when
repository.clear()

// then
verify(messageDao).deleteAll()
verify(messageDao).deleteAllDrafts()
verify(replyMessageDao).deleteAll()
}
}
Loading