fix: state synchronisity mismatch #3352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes an unfortunate issue with state not being properly synchronized in certain situations (typically on lower end devices), where the updates of our
processedMessageListwould be ahead of the updates of the previous and nextmessagestore.Even thought there's a dependency on
processedMessageList, sincerenderItemis already memoized and themessagereferences are stable from the work done on theMessageListthe past few months, this does not in fact degrade performance while we focus on correctness.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch