-
Notifications
You must be signed in to change notification settings - Fork 291
feat: add optional Delete for me message action #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinCupela
merged 3 commits into
master
from
feat/add-deleted-for-me-message-operation
Oct 9, 2025
Merged
feat: add optional Delete for me message action #2855
MartinCupela
merged 3 commits into
master
from
feat/add-deleted-for-me-message-operation
Oct 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +966 B (+0.08%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
7fea234 to
d622cf7
Compare
oliverlaz
approved these changes
Oct 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2855 +/- ##
=======================================
Coverage 81.46% 81.47%
=======================================
Files 495 495
Lines 10010 10015 +5
Branches 2278 2280 +2
=======================================
+ Hits 8155 8160 +5
Misses 1741 1741
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 13.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes REACT-598
Depends on GetStream/stream-chat-js#1604
🛠 Implementation details
The "Delete for me" action is displayed if it is enabled as follows
The message returned in the delete message server is still of type
"regular"and does not havedeleted_for_meproperty, so we need to update those on our side.I had to enable passing
DeleteMessageOptionsto the delete message handler and wrapper function in order not to break the existing pattern.🎨 UI Changes
Docs
https://github.com/GetStream/docs-content/pull/662