[CHA-2578] chore: relax faraday and sorbet-runtime version constraints#200
Merged
nijeesh-stream merged 6 commits intomasterfrom Mar 5, 2026
Merged
[CHA-2578] chore: relax faraday and sorbet-runtime version constraints#200nijeesh-stream merged 6 commits intomasterfrom
nijeesh-stream merged 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
cae3f59 to
c334fe8
Compare
- faraday: ~> 2.12.2 -> ~> 2.12 (unblocks security fix in 2.14.1) - faraday-multipart: ~> 1.1.0 -> ~> 1.1 (allows 1.2.x, Ruby 4 compat) - faraday-net_http_persistent: ~> 2.3.0 -> ~> 2.3 - sorbet-runtime: ~> 0.5.11820 -> >= 0.5.11820, < 2 (allows 0.5.x and 0.6.x) - sorbet (dev): ~> 0.5 -> ~> 0.6 Closes #196, closes #189
- Remove conflicting method stubs from hidden.rbi (now in Sorbet 0.6 stdlib) - Add typed: true headers to gem RBIs missing sigils - Ignore sorbet/rbi/sorbet-typed in sorbet config (stale 0.5 community stubs) - Delete sorbet/rbi/sorbet-typed (ignored, 1071 lines of stale stubs removed)
c6e2d61 to
5086c47
Compare
…by version check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Current sorbet versions are 0.5.x and 0.6.x, both of which are < 1. Using < 2 was unnecessarily wide and would allow a hypothetical 1.x series without explicit opt-in.
vishalnarkhede
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket
https://linear.app/stream/issue/CHA-2578/update-stream-chat-ruby-gemspec-unblock-sorbet-runtime-06-and-faraday
Relaxes dependency version constraints to unblock security fixes and improve Ruby 4.0 compatibility. No breaking changes — all constraints are widened, not tightened.
Dependency changes
faraday~> 2.12.2~> 2.12faraday-multipart~> 1.1.0~> 1.1faraday-net_http_persistent~> 2.3.0~> 2.3sorbet-runtime~> 0.5.11820>= 0.5.11820, < 1sorbet(dev)~> 0.5~> 0.6CI changes
ruby == '3.4'to alint: truematrix flag — cleaner and easier to maintain as versions are addedSorbet 0.6 RBI compatibility
Sorbet 0.6 changed the default typing level for RBI files without a
# typed:sigil fromtruetostrict, causing errors in stale autogenerated stubs. Fixed in three ways:sorbet/rbi/sorbet-typed/— added to--ignoreinsorbet/config. These are community stubs for dev tools (rake, rspec, rubocop) that don't affect source type checking.sorbet/rbi/gems/— added# typed: trueto 16 files that were missing sigils.sorbet/rbi/hidden-definitions/hidden.rbi— removedsuggest_gems_from_nameandwait_readable, now covered by Sorbet 0.6's built-in stdlib RBIs.srb tcpasses with zero errors onlib/.Impact on consumers
None. Existing users on Faraday 2.12.x are unaffected. Users who want the Faraday 2.14.1 security fix are now unblocked. The
sorbet-runtimerange covers both 0.5.x and 0.6.x.Follow-up
sorbet/rbi/generation from deprecatedsrb rbito Tapioca to properly regenerate all stubs and remove thesorbet/rbi/sorbet-typed/directory.