deck get ...geyfra-demos.git fails on openSUSE

[rolandg333]

INFO] Deck version: 0.9.5

$ deck get https://github.com/gefyrahq/gefyra-demos.git

fails on openSuse with error message:

[CRITICAL] There was an error running deck: The command '/bin/sh -c addgroup -g ${GROUP_ID} -S tooler && adduser -u ${USER_ID} -S tooler -G tooler' returned a non-zero code: 1

'addgroup' and 'adduser' are commands not available on all kind of linux distributions.
porting to 'groupadd' and 'useradd' might be a good solution ( an should be easy )

[Schille]

Hi @rolandg333
Thank you for bringing this up.

The tooler (a container image) component is built on each system when running for the first time. The code for the adduser/addgroup is this:

getdeck/getdeck/sources/tooler.py

Lines 86 to 89 in 368b0c2

	if sys.platform in ["darwin", "win32"]:
	user_group_add = "RUN addgroup -S tooler && adduser -S tooler -G tooler"
	else:
	user_group_add = "RUN addgroup -g ${GROUP_ID} -S tooler && adduser -u ${USER_ID} -S tooler -G tooler"

Currently, there is a branch for Windows and Mac; all Linux distros fall in the else branch.

[rolandg333]

Hi Michael, i already found the sources, and the place where i would change. but how do i build the whole project, or test any change by myself.

…

On Fri, Oct 14, 2022 at 9:49 AM Michael Schilonka ***@***.***> wrote: Hi @rolandg333 <https://github.com/rolandg333> Thank you for bringing this up. The tooler (a container image) component is built on each system when running for the first time. The code for the *adduser*/*addgroup* is this: https://github.com/Getdeck/getdeck/blob/main/getdeck/sources/tooler.py#L86-L89 Currently, there is a branch for Windows and Mac; all Linux distros fall in the else branch. — Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD3JMAGPAI4CRXFK4PGEYRLWDEF67ANCNFSM6AAAAAARE6KDFQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[buschNT]

Hi @rolandg333 ,

currently, you would still have to test your changes manually. We are actively working on adding a better test setup and more tests, but this takes a little bit more time.

I develop using a venv. Then I run getdeck commands with the venv activated using python -m getdeck <COMMAND> and manually test changes.
Or in case you are using VSCode, you can add the following to the configurations in your launch.json:

        {
            "name": "development",
            "type": "python",
            "request": "launch",
            "module": "getdeck",
            "justMyCode": true,
            "args": [
                "get",
                "<DECKFILE>"
            ]
        },

Sometimes you might have to add the "cwd": option, too, depending on where the deck file is located.

In order to test changes on the tooler, you have to delete your local tooler image in order to trigger a rebuild:

getdeck/getdeck/sources/tooler.py

Lines 27 to 30 in 368b0c2

	try:
	config.DOCKER.images.get(config.TOOLER_USER_IMAGE)
	except docker.errors.ImageNotFound:
	build_user_container(config)

I created an issue regarding a development setup documentation: #86

Hopefully my short development description helps, if not feel free to point out what's unclear.

[Z02X]

Mentioning this here so my issue #93 can be closed as duplicate. I believe the issue could be caused when the id's are 0, sutch as when run as root. I don't think it could be the commands missing.

[rolandg333]

the fix for #101 is not working on openSUSE. i face still the same error

i've added a debug line and found:
[DEBUG] Tooler build_args: {'USER_ID': '1000', 'GROUP_ID': '100'}

because:
$ id
uid=1000(roland) gid=100(users) Gruppen=100(users),459(libvirt),460(qemu),463(docker),482(systemd-journal),487(kvm),496(wheel)

the docker image quay.io/getdeck/tooler is based on alpine linux; a group with gid 100 is already existing. the addgroup call fails.

when I override gid in

--- a/getdeck/sources/tooler.py
+++ b/getdeck/sources/tooler.py
@@ -79,6 +79,7 @@ def build_user_container(config: ClientConfiguration):
     if sys.platform != "win32":
         uid = os.getuid() or 1000
         gid = os.getgid() or 1000
+        gid = 1000
     else:
         uid = 1000
         gid = 1000

the tooler image gets created.

but i guess you try to pick up the uid and gid of the user on purpose ...

[Schille]

@rolandg333 thank you for your eager testing and your results.
I will think about another solution then.

The point of mapping the user and group id is for the correct ownership of the generated files (in a mounted volume) later in the process. We want to write the files from within the docker container with the same user identity as the user calling deck.