Skip to content

Conversation

@schwobaseggl
Copy link
Collaborator

Ability to:

  • provide hosts in deck file
  • list them
  • write them to hosts file
  • remove them from hosts file

Veit Rückert added 6 commits June 17, 2022 16:18
add automatic  subprocess call
add check for host resolution
# Conflicts:
#	poetry.lock
Use extra "hosts" key under deck to identify hosts
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2762381869

  • 42 of 73 (57.53%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 63.071%

Changes Missing Coverage Covered Lines Changed/Added Lines %
getdeck/main.py 5 7 71.43%
getdeck/api/get.py 14 16 87.5%
getdeck/api/hosts.py 12 39 30.77%
Files with Coverage Reduction New Missed Lines %
getdeck/k8s.py 8 60.99%
Totals Coverage Status
Change from base Build 2710808289: -1.0%
Covered Lines: 994
Relevant Lines: 1576

💛 - Coveralls

@buschNT buschNT merged commit 961e95e into main Aug 1, 2022
@buschNT
Copy link
Contributor

buschNT commented Aug 1, 2022

@schwobaseggl I merged the PR. The only thing that is missing is the documentation on how to use it. I guess we should add a small section to the docs.

@buschNT buschNT mentioned this pull request Aug 1, 2022
@buschNT buschNT deleted the #21 branch August 11, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants