Skip to content

fix: move namespace selection #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Schille merged 1 commit into from
Aug 12, 2022
Merged

fix: move namespace selection #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions getdeck/sources/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ def prepare_k8s_workload_for_deck(
)
continue

fetcher_context.strategy = strategy(
deckfile.file_path, source, config, namespace
)

# if a source, such as Helm, specifies another namespace
logger.debug(source)
if hasattr(source, "namespace"):
namespace = source.namespace or deck.namespace or "default"
else:
namespace = deck.namespace or "default"

fetcher_context.strategy = strategy(
deckfile.file_path, source, config, namespace
)

# fetch source files
source_files = fetcher_context.fetch_source_files()
generated_deck.files.extend(source_files)
Expand Down