Skip to content

Conversation

@buschNT
Copy link
Contributor

@buschNT buschNT commented Oct 7, 2022

- preparation for bugfixes + features regarding deckfile, e.g. #81
- decouple deckfile fetching from parsing
- tests added
@buschNT buschNT requested a review from Schille October 7, 2022 14:09
@buschNT buschNT self-assigned this Oct 7, 2022
@coveralls
Copy link

coveralls commented Oct 7, 2022

Pull Request Test Coverage Report for Build 3205915364

  • 92 of 150 (61.33%) changed or added relevant lines in 9 files are covered.
  • 7 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.5%) to 63.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
getdeck/api/hosts.py 1 2 50.0%
getdeck/api/list.py 1 2 50.0%
getdeck/api/remove.py 2 3 66.67%
getdeck/utils.py 17 23 73.91%
getdeck/deckfile/fetch/utils.py 4 19 21.05%
getdeck/deckfile/fetch/deck_fetcher.py 58 92 63.04%
Files with Coverage Reduction New Missed Lines %
getdeck/api/get.py 1 71.43%
getdeck/api/hosts.py 1 31.11%
getdeck/api/list.py 1 56.25%
getdeck/api/stop.py 1 93.75%
getdeck/utils.py 1 58.79%
getdeck/api/remove.py 2 30.51%
Totals Coverage Status
Change from base Build 3152532040: 0.5%
Covered Lines: 1201
Relevant Lines: 1889

💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Schille Schille merged commit 73db788 into main Oct 17, 2022
@Schille Schille deleted the feature/fetch-deck-strategy branch October 17, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants