Chrome State Key Parsing Bugfix #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor bugfix to address how the statekeys are pulled from later versions of Chrome's local state file. The bug is a result of parsing the JSON file via an
indexOf()against theencrypted_keysubstring. Many versions of Chrome I tested have two JSON keys withencrypted_keyin the name. When theapp_bound_encrypted_keyJSON key comes before theencrypted_keykey within the file, SharpChrome pulls the former and attempts to decrypt it as a state key.This will cause SharpChrome to fail with the following error message:
The simple fix is to update the search term to be quote-wrapped, ensuring a perfect match on the expected key. Ideally, we would use JSON/Lync to parse this file, but I'm not sure if this introduces unwanted behavior under different conditions. In order to prevent this change from affecting other environments, the
Chrome.GetBase64EncryptedKey()function will search for the quote-wrapped search term and if it fails to find the value, will fall back to the original non-quote-wrapped search term.