[Future] Fix issues in register donor page#227
Open
jamessspanggg wants to merge 2 commits intomasterfrom
Open
Conversation
jinyingtan
reviewed
Jul 31, 2020
| const provider = new firebase.auth.GoogleAuthProvider(); | ||
| // allow user to select own account | ||
| provider.setCustomParameters({ | ||
| prompt: 'select_account', |
Contributor
There was a problem hiding this comment.
By setting this, means that when you login, you will always need to select an account?
Contributor
Author
There was a problem hiding this comment.
To add on, when currently using desktop (safari, chrome), it always asks to select an account. But only for mobile, it automatically selects.
This addition causes the mobile to ask for selection before logging in as well.
jamessspanggg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign in->registerFixes issue 9 in google docs