Merged
Conversation
nmaarnio
commented
Feb 4, 2025
nmaarnio
commented
Feb 10, 2025
Collaborator
Author
nmaarnio
left a comment
nmaarnio
left a comment
There was a problem hiding this comment.
See my comment below. Also, agterberg_cheng_CI_test should also take in the weights_df instead of nr of deposits
Read number of deposits and pixels as max values (instead of sums) of corresponding columns in the input df.
Instead of user providing number of deposits as int type parameter, read it from input df.
Add function to calculate nr of deposits and pixels from weights dataframe using input array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.