fix: remove debug artifacts and fix password reset token log exposure#112
Merged
Conversation
- Delete GET /auth/test debug endpoint and bcrypt import - Remove raw reset token and reset URL from application logs; replace with neutral 'Password reset requested for user ID: X' log entry - Gate Swagger UI behind NODE_ENV !== 'production' - Remove persistAuthorization from Swagger options Closes #99
Contributor
There was a problem hiding this comment.
Pull request overview
Removes debug/security-sensitive artifacts from the auth flow and limits Swagger UI exposure to non-production environments.
Changes:
- Removed the
GET /auth/testdebug endpoint and itsbcryptimport fromAuthController. - Eliminated password reset token/reset-link logging; replaced with a neutral user-ID log line.
- Mounted Swagger UI only when
NODE_ENV !== 'production'and removedpersistAuthorization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/src/modules/auth/auth.service.ts | Stops logging password reset token/URL; logs only a neutral request message. |
| backend/src/modules/auth/auth.controller.ts | Deletes the debug bcrypt test endpoint and related import. |
| backend/src/main.ts | Gates Swagger UI to non-production and removes persisted authorization option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Swagger docs URL was being logged unconditionally even when the UI itself was not mounted in production. Moves the log line inside the same NODE_ENV !== 'production' guard for consistency.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /auth/testdebug endpoint and itsbcryptimport fromAuthControllerrequestPasswordReset()that leaked the raw token and reset URL with a single neutral log:Password reset requested for user ID: X/api/docs) behindNODE_ENV !== 'production'persistAuthorization: truefrom Swagger optionsTest plan
GET /auth/testreturns 404POST /auth/forgot-passwordlogs onlyPassword reset requested for user ID: X— no token, no URL/api/docsin development (NODE_ENV=development)NODE_ENV=productionCloses #99