-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: eliminate TypeScript any types across backend and frontend #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9b05dc3
feat: add TypeScript interfaces for JWT authentication
GitAddRemote ae6a780
refactor: update auth module to use typed interfaces
GitAddRemote 2354545
refactor: replace any types in controllers with AuthenticatedRequest
GitAddRemote 3fdfd47
refactor: implement typed DTOs for UEX repository update operations
GitAddRemote 1c29125
refactor: improve error handling with proper type narrowing
GitAddRemote 0a6a1d3
refactor: use Record<string, unknown> for audit log metadata
GitAddRemote 361eb4b
feat: add scheduled refresh token cleanup job
GitAddRemote 5c17161
refactor: eliminate TypeScript any types across backend and frontend
GitAddRemote 213d2f9
refactor: address PR review items for ISSUE-100
GitAddRemote 11f4e76
chore: merge main into feat/ISSUE-100-eliminate-typescript-any
GitAddRemote ac317c2
refactor: address remaining PR #122 review items
GitAddRemote 142361a
refactor: eliminate explicit any types from spec files
GitAddRemote eaeaa2b
fix: resolve TypeScript compile errors in spec files after any elimin…
GitAddRemote dcb5384
refactor: address final code review items on PR #122
GitAddRemote db26cfe
refactor: address code review items from latest PR #122 review round
GitAddRemote 8f3cd6d
fix: restore userId field name in getProfile response
GitAddRemote 4ce2a06
fix: address password leak and query param type narrowness
GitAddRemote 8a722fe
fix: correct me endpoint field name and audit log plain-object guard
GitAddRemote baa8bc3
refactor: eliminate unknown cast in BaseUexRepository update methods
GitAddRemote a2dbc4b
fix: validate numeric query params in UserInventoryController.list()
GitAddRemote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,3 +50,4 @@ UEX_BACKOFF_BASE_MS=1000 | |
| UEX_RATE_LIMIT_PAUSE_MS=2000 | ||
| UEX_ENDPOINTS_PAUSE_MS=2000 | ||
| UEX_API_KEY= | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,24 @@ | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| 'use strict'; | ||
| Object.defineProperty(exports, '__esModule', { value: true }); | ||
| exports.AppDataSource = void 0; | ||
| require("dotenv/config"); | ||
| const typeorm_1 = require("typeorm"); | ||
| const user_entity_1 = require("./src/modules/users/user.entity"); | ||
| require('dotenv/config'); | ||
| const typeorm_1 = require('typeorm'); | ||
| const user_entity_1 = require('./src/modules/users/user.entity'); | ||
| exports.AppDataSource = new typeorm_1.DataSource({ | ||
| type: 'postgres', | ||
| host: process.env.DATABASE_HOST, | ||
| port: parseInt(process.env.DATABASE_PORT || '0'), | ||
| username: process.env.DATABASE_USER, | ||
| password: process.env.DATABASE_PASSWORD, | ||
| database: process.env.DATABASE_NAME, | ||
| entities: [user_entity_1.User], | ||
| migrations: ['src/migrations/*.ts'], | ||
| synchronize: false, | ||
| type: 'postgres', | ||
| host: process.env.DATABASE_HOST, | ||
| port: parseInt(process.env.DATABASE_PORT || '0'), | ||
| username: process.env.DATABASE_USER, | ||
| password: process.env.DATABASE_PASSWORD, | ||
| database: process.env.DATABASE_NAME, | ||
| entities: [user_entity_1.User], | ||
| migrations: ['src/migrations/*.ts'], | ||
| synchronize: false, | ||
| }); | ||
| exports.AppDataSource.initialize() | ||
| .then(() => { | ||
| .then(() => { | ||
| console.log('Data Source has been initialized!'); | ||
| }) | ||
| .catch((err) => { | ||
| }) | ||
| .catch((err) => { | ||
| console.error('Error during Data Source initialization:', err); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export interface QueryParams { | ||
| [key: string]: string | string[] | QueryParams | QueryParams[] | undefined; | ||
| } | ||
|
|
||
| /** Narrows a query param value to string | undefined, ignoring arrays/objects. */ | ||
| export function asString(value: QueryParams[string]): string | undefined { | ||
| return typeof value === 'string' ? value : undefined; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.