-
Notifications
You must be signed in to change notification settings - Fork 63
Resolving BuG: Fixed bug in signup page issue #176 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving BuG: Fixed bug in signup page issue #176 #177
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughThe Signup page was updated to use a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SignupPage
participant Router
User->>SignupPage: Clicks "Sign in here"
SignupPage->>Router: Navigates to "/login"
Router-->>User: Renders LoginPage
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested labels
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/pages/Signup/Signup.tsx (1)
3-3: Fix spacing in import statement.The spacing around the comma in the import statement is inconsistent.
Apply this diff for better formatting:
-import { useNavigate ,Link } from "react-router-dom"; +import { useNavigate, Link } from "react-router-dom";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/Signup/Signup.tsx(3 hunks)
🔇 Additional comments (2)
src/pages/Signup/Signup.tsx (2)
61-61: LGTM! Good positioning context.Adding the
relativeclass provides proper positioning context for the layout. This is a solid improvement.
1-165: Header and Footer functionality verified in App.tsxNavbar and Footer components are imported and rendered in
src/App.tsx, wrapping the<main>content (which includes the signup page). This confirms header/footer fixes apply globally—including on the signup page.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
🎉🎉 Thank you for your contribution! Your PR #177 has been merged! 🎉🎉 |
Related Issue
Description
Header and Footer is Not working in signup page and in signup page back to login link is not working .
How Has This Been Tested?
I fixed the bug in signup page , Now Header and Footer is fixed properly . I have tested this in Npm run preview to see it it working in production ENV.
Screenshots (if applicable)
Type of Change
Summary by CodeRabbit
New Features
Style