Skip to content

Conversation

@Harshitraaaj
Copy link
Contributor

@Harshitraaaj Harshitraaaj commented Aug 6, 2025

Related Issue


Description

Header and Footer is Not working in signup page and in signup page back to login link is not working .


How Has This Been Tested?

I fixed the bug in signup page , Now Header and Footer is fixed properly . I have tested this in Npm run preview to see it it working in production ENV.


Screenshots (if applicable)


Type of Change

  • Bug fix
  • New feature
  • Code style update
  • Breaking change
  • Documentation update

Summary by CodeRabbit

  • New Features

    • The "Sign in here" option on the signup page now navigates directly to the login page, improving user experience.
  • Style

    • Adjusted layout styling for more consistent positioning on the signup page.

@netlify
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for github-spy ready!

Name Link
🔨 Latest commit b42258b
🔍 Latest deploy log https://app.netlify.com/projects/github-spy/deploys/68938b0772f85f0008a3dd87
😎 Deploy Preview https://deploy-preview-177--github-spy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The Signup page was updated to use a Link component from react-router-dom for navigation to the login page. The previous button, which only logged a message, was replaced with a functioning link. Minor container class adjustments were also made for layout positioning.

Changes

Cohort / File(s) Change Summary
Signup Page Navigation Update
src/pages/Signup/Signup.tsx
Replaced the "Sign in here" button with a Link to /login for proper navigation; updated container class.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SignupPage
    participant Router

    User->>SignupPage: Clicks "Sign in here"
    SignupPage->>Router: Navigates to "/login"
    Router-->>User: Renders LoginPage
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Fix Signup page "back to login" link to enable navigation (#176)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

Suggested labels

level1

Poem

A hop and a skip, now the link is just right,
From signup to login, you’ll travel in light!
No more console logs—just seamless delight,
Navigation’s a breeze, with each click taking flight.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f595b27 and b42258b.

📒 Files selected for processing (1)
  • src/pages/Signup/Signup.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/pages/Signup/Signup.tsx (1)

3-3: Fix spacing in import statement.

The spacing around the comma in the import statement is inconsistent.

Apply this diff for better formatting:

-import { useNavigate ,Link } from "react-router-dom";
+import { useNavigate, Link } from "react-router-dom";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07e185f and f595b27.

📒 Files selected for processing (1)
  • src/pages/Signup/Signup.tsx (3 hunks)
🔇 Additional comments (2)
src/pages/Signup/Signup.tsx (2)

61-61: LGTM! Good positioning context.

Adding the relative class provides proper positioning context for the layout. This is a solid improvement.


1-165: Header and Footer functionality verified in App.tsx

Navbar and Footer components are imported and rendered in src/App.tsx, wrapping the <main> content (which includes the signup page). This confirms header/footer fixes apply globally—including on the signup page.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@mehul-m-prajapati mehul-m-prajapati merged commit 988166d into GitMetricsLab:main Aug 6, 2025
5 of 6 checks passed
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

🎉🎉 Thank you for your contribution! Your PR #177 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Signup page Login and Navbar links are not Working

2 participants