Skip to content

Conversation

@arshitcc
Copy link
Contributor

Related Issue


Description


How Has This Been Tested?


Screenshots (if applicable)


Type of Change

  • Bug fix
  • New feature
  • Code style update
  • Breaking change
  • Documentation update

@netlify
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for github-spy ready!

Name Link
🔨 Latest commit 7ef7d82
🔍 Latest deploy log https://app.netlify.com/sites/github-spy/deploys/678ac5da4c105700080d643a
😎 Deploy Preview https://deploy-preview-75--github-spy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yashksaini-coder
Copy link

Kindly share a working demo if possible @arshitcc

@arshitcc
Copy link
Contributor Author

@yashksaini-coder

Here is the recorded link:
https://www.loom.com/share/e5e028f6cbee4eed89d117b96488277c?sid=11876289-62d1-4826-9a6d-cb64f4c77ca4

Copy link

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehul-m-prajapati The Github Auth works fine and the code is clean, Review the PR on your end.

Copy link

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Github login feat is good, thank you for your contribution @arshitcc

@yashksaini-coder
Copy link

@mehul-m-prajapati I think we can merge this, the GitHub auth feat is very good

@mehul-m-prajapati
Copy link
Collaborator

ok @yashksaini-coder , thanks for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add "Sign In with GitHub"

3 participants