This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Disable input sounds when in password mode #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitSquared
reviewed
Feb 17, 2021
Co-authored-by: Gaby <gabriel@saillard.dev>
Owner
|
Thanks for working on this! |
Contributor
Author
|
No problem! |
eugene2candy
pushed a commit
to eugene2candy/edex-ui
that referenced
this pull request
Apr 10, 2021
* Extend file editing capabilities * Add git files to the supported file types list * Replace single filetype handling with MIME handling * update submodules * use mime.charset to tell which files are text-readable * Stop sounds from playing on key press when in password mode * Fix little mistake on line 347 Co-authored-by: Gaby <gabriel@saillard.dev> Co-authored-by: Gabriel Saillard <gabriel@saillard.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1039
When password mode is enabled, I've disabled the sounds that get played when pressing a key. This included the stdout sound that gets played when the terminal recieves another piece of text as I found that when typing in the terminal, it played the sound. I will make changes if requested/as needed.
small edit: I'm not sure why the commit log shows stuff from my last PR, but there shouldn't be any changes made to that part eDEX